Deprecate certificate #1286
Open
Deprecate certificate #1286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
requested review from
carbolymer,
disassembler,
kevinhammond,
newhoggy and
palas
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jimbo4350
force-pushed
the
jordan/final-deprecate-certificate
branch
from
cc4a1a2 to
b387201
Compare
Jimbo4350
force-pushed
the
jordan/final-deprecate-certificate
branch
from
b387201 to
8f23987
Compare
carbolymer
reviewed
Sep 25, 2025
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "type": "CertificateConway", | |||
| "type": "Certificate", | |||
Contributor
There was a problem hiding this comment.
We should make sure that cardano-testnet and cardano-node-tests pass with this change. I suppose the change to legacyComparison here https://github.com/IntersectMBO/cardano-api/pull/962/files should do the job.
carbolymer
reviewed
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: IntersectMBO/cardano-api#962
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist